Reply to post: Static Analysis ftw

Get ready to patch Git servers, clients – nasty-looking bugs surface

CommodorePet

Static Analysis ftw

Stratic analysis tools would raise a bunch of issues here.

strlen returns a size_t, which is unsigned. Mixing signed and unsigned with an inequality if statement is a big red flag.

I agree with an earlier point, concating strings and general path manipulation should be a solved problem.

POST COMMENT House rules

Not a member of The Register? Create a new account here.

  • Enter your comment

  • Add an icon

Anonymous cowards cannot choose their icon

SUBSCRIBE TO OUR WEEKLY TECH NEWSLETTER

Biting the hand that feeds IT © 1998–2021